Resolves #776: onlyUpgradable change the filter to versions where the current version is not the latest one #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slawekjaranowski Please review and merge. |
|
Converting to draft -- I'll quickly try to do it properly. Looks like it's now working and is done properly. |
…here the current version is not the latest one
andrzejj0
force-pushed
the
issue-776-only-upgradable-not-working
branch
from
7aaf138
to
6c347a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause of the issue:
VersionsHelper.lookupDependenciesUpdatesactually returns all dependency versions, and not just updates.The problem manifested itself when the currently used version was the latest, but there were more versions reported (older than the current one).
This is now corrected, i.e. the method returns only updates, in contrast to
lookupArtifactVersions.onlyUpgradableOnlylooks to work fine now. Updated the unit tests to test also for cases when the version used by an artifact is the latest version, but there are more available versions (older than the current one).Removed some redundant classes implementing
Callable, which could very easily be inlined which results in a much cleaner code.Also, as a minor pedantic fix, corrected the "splitted" [sic] to "split" in one method name.